Remove subcategory enums from program and l3_common#893
Open
braingram wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 15 15
Lines 1131 1131
=======================================
Hits 973 973
Misses 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
braingram
requested review from
a team,
WilliamJamieson,
jbrookens and
kdupriestsci
as code owners
WilliamJamieson
approved these changes
Jul 6, 2026
braingram
force-pushed
the
rm_subcategory_enum
branch
from
4dbd729 to
ef3681d
Compare
Collaborator
|
This looks good to me. I took the opportunity to review the use of enums more broadly in rad/latest in #894 . At least visit type probably should get similar treatment to subcategory, but that will need RTB review first, etc.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #889
Removes the subcategory enums in program and l3_common.
Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/28548621560
show 2 expected differences for tvac data where subcategory is
?with this PR instead ofCALon main (both from the use ofcreate_fake_datain processing tvac data).Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change